adminuser

Webshop.Application/Services/Admin/AdminUserService.cs

@@ -4,30 +4,26 @@ using Microsoft.EntityFrameworkCore;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
+using Webshop.Application;
 using Webshop.Application.DTOs.Users;
 using Webshop.Application.Services.Admin.Interfaces;
-using Webshop.Domain.Entities;
-using Webshop.Infrastructure.Data; // WICHTIG: Stellt sicher, dass ApplicationDbContext gefunden wird.
 using Webshop.Domain.Identity;
+using Webshop.Infrastructure.Data;
 
 namespace Webshop.Application.Services.Admin
 {
-    // --- SCHRITT 1: Die fehlende Klassendeklaration ---
     public class AdminUserService : IAdminUserService
     {
-        // --- SCHRITT 2: Die fehlenden Feld-Deklarationen ---
         private readonly UserManager<ApplicationUser> _userManager;
         private readonly ApplicationDbContext _context;
 
-        // --- SCHRITT 3: Der Konstruktor, der die Felder zuweist ---
         public AdminUserService(UserManager<ApplicationUser> userManager, ApplicationDbContext context)
         {
             _userManager = userManager;
             _context = context;
         }
 
-        // --- AB HIER: Alle Ihre Methoden, unverändert ---
-        public async Task<IEnumerable<UserDto>> GetAllUsersAsync()
+        public async Task<ServiceResult<IEnumerable<UserDto>>> GetAllUsersAsync()
         {
             var users = await _userManager.Users
                 .Include(u => u.Customer)
@@ -49,10 +45,10 @@ namespace Webshop.Application.Services.Admin
                     LastName = user.Customer?.LastName ?? string.Empty
                 });
             }
-            return userDtos;
+            return ServiceResult.Ok<IEnumerable<UserDto>>(userDtos);
         }
 
-        public async Task<UserDto?> GetUserByIdAsync(string userId)
+        public async Task<ServiceResult<UserDto>> GetUserByIdAsync(string userId)
         {
             var user = await _userManager.Users
                 .Include(u => u.Customer)
@@ -60,10 +56,10 @@ namespace Webshop.Application.Services.Admin
 
             if (user == null)
             {
-                return null;
+                return ServiceResult.Fail<UserDto>(ServiceResultType.NotFound, $"Benutzer mit ID '{userId}' nicht gefunden.");
             }
 
-            return new UserDto
+            var userDto = new UserDto
             {
                 Id = user.Id,
                 Email = user.Email ?? string.Empty,
@@ -75,33 +71,42 @@ namespace Webshop.Application.Services.Admin
                 FirstName = user.Customer?.FirstName ?? string.Empty,
                 LastName = user.Customer?.LastName ?? string.Empty
             };
+
+            return ServiceResult.Ok(userDto);
         }
 
-        public async Task<bool> UpdateUserRolesAsync(string userId, List<string> newRoles)
+        public async Task<ServiceResult> UpdateUserRolesAsync(string userId, List<string> newRoles)
         {
             var user = await _userManager.FindByIdAsync(userId);
             if (user == null)
             {
-                return false;
+                return ServiceResult.Fail(ServiceResultType.NotFound, $"Benutzer mit ID '{userId}' nicht gefunden.");
             }
 
             var existingRoles = await _userManager.GetRolesAsync(user);
             var removeResult = await _userManager.RemoveFromRolesAsync(user, existingRoles);
             if (!removeResult.Succeeded)
             {
-                return false;
+                string errors = string.Join(", ", removeResult.Errors.Select(e => e.Description));
+                return ServiceResult.Fail(ServiceResultType.Failure, $"Fehler beim Entfernen alter Rollen: {errors}");
             }
 
             var addResult = await _userManager.AddToRolesAsync(user, newRoles);
-            return addResult.Succeeded;
+            if (!addResult.Succeeded)
+            {
+                string errors = string.Join(", ", addResult.Errors.Select(e => e.Description));
+                return ServiceResult.Fail(ServiceResultType.Failure, $"Fehler beim Hinzufügen neuer Rollen: {errors}");
+            }
+
+            return ServiceResult.Ok();
         }
 
-        public async Task<bool> DeleteUserAsync(string userId)
+        public async Task<ServiceResult> DeleteUserAsync(string userId)
         {
             var user = await _userManager.FindByIdAsync(userId);
             if (user == null)
             {
-                return false;
+                return ServiceResult.Fail(ServiceResultType.NotFound, $"Benutzer mit ID '{userId}' nicht gefunden.");
             }
 
             // Kaskadierendes Löschen der abhängigen Daten
@@ -122,8 +127,13 @@ namespace Webshop.Application.Services.Admin
 
             // Zum Schluss den Identity-Benutzer löschen
             var result = await _userManager.DeleteAsync(user);
-            return result.Succeeded;
-        }
+            if (!result.Succeeded)
+            {
+                string errors = string.Join(", ", result.Errors.Select(e => e.Description));
+                return ServiceResult.Fail(ServiceResultType.Failure, $"Fehler beim Löschen des Benutzers: {errors}");
+            }
 
-    } // <-- Schließende Klammer für die Klasse
-} // <-- Schließende Klammer für den Namespace
+            return ServiceResult.Ok();
+        }
+    }
+}